Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fullscreen button behavior and toolbar visibility #1690

Closed
wants to merge 1 commit into from

Conversation

Devmoni
Copy link

@Devmoni Devmoni commented Dec 29, 2024

Fix : #1689

Description:

This PR addresses the issue with the fullscreen button behavior. The fullscreen mode is now implemented to maximize the app without hiding the toolbar. The fullscreen button is replaced by the unfullscreen button when activated.

Changes:

  • Implemented fullscreen functionality while keeping the toolbar visible.
  • Added proper toggling of fullscreen and unfullscreen buttons.

Note:

I have implemented this functionality for the Calculate activity to demonstrate the current behavior. Once approved, this can be extended to other activities for consistency across the app.

- Implement fullscreen mode without hiding the toolbar.
- Toggle fullscreen and unfullscreen buttons correctly.
@AdityaKrSingh26
Copy link

Create the PR on dev branch only. Go through this once : https://github.com/llaske/sugarizer/blob/master/CONTRIBUTING.md

@Devmoni
Copy link
Author

Devmoni commented Dec 29, 2024

I apologize for the error.

@Devmoni Devmoni closed this Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen Button Hides Toolbar Instead of Maximizing to Fullscreen
2 participants