[OMPT] Linking with libraries that provide "RunningOnValgrind" symbols causes "Unable to find TSan function" messages

[paulfloyd]

Off-topic remark. I'm a bit baffled as to why TSAN has a "RunningOnValgrind" that doesn't do what it says (it doesn't detect that the exe is running on Valgrind, it just looks at the TSAN_OPTIONS).

The app that I'm working on uses Google Perftools tcmallloc. I'm doing some tests with LLVM OMP.

So when I run our exe I get

Unable to find TSan function AnnotateHappensAfter.
Unable to find TSan function AnnotateHappensBefore.
Unable to find TSan function AnnotateIgnoreWritesBegin.
Unable to find TSan function AnnotateIgnoreWritesEnd.
Unable to find TSan function AnnotateNewMemory.
Unable to find TSan function __tsan_func_entry.
Unable to find TSan function __tsan_func_exit.
Warning: please export TSAN_OPTIONS='ignore_noninstrumented_modules=1' to avoid false positive reports from the OpenMP runtime!

This is similar to issue #93524

This is because you are checking for TSAN with a function called "RunningOnValgrind". However, tcmalloc also contains a "RunningOnValgrind".
(booby prize for Google Perftools as well, their RunningOnValgrind also does not detect that the exe is running on Valgrind).

I'm doing a test, trying to use "_tsan_init" rather than "RunningOnValgrind". I'll update soon if it looks OK.