Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Library to lazerpay #15

Open
appcypher opened this issue Mar 6, 2022 · 5 comments
Open

Rename Library to lazerpay #15

appcypher opened this issue Mar 6, 2022 · 5 comments

Comments

@appcypher
Copy link
Contributor

appcypher commented Mar 6, 2022 •
edited
Loading

I think the library should just be renamed lazerpay or lazerpay-rs. lazerpay-rust-sdk is a mouthful.
There is no need for the ...-rust-sdk namespacing since this rust version is only ever going to exist in crates-verse.

It also helps with discoverability.
@appcypher appcypher changed the title Just Call Library lazerpay Rename Library to lazerpay Mar 6, 2022
@ECJ222
Copy link
Collaborator

ECJ222 commented Mar 6, 2022

What do you think @Lord-sarcastic ?

@lordsarcastic
Copy link
Owner

I think it makes sense, and we should do it. The current naming was just in a bid to follow the convention from existing Lazerpay SDKs

@lordsarcastic
Copy link
Owner

Will fix this today

@lordsarcastic
Copy link
Owner

Seems like I'll await the current pull request to be merged, then I do the fix

@appcypher
Copy link
Contributor Author

Bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@appcypher @lordsarcastic @ECJ222