Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text that convert interval seconds to days, hours, minutes, seconds #3601

Open
1 task done
bernarddt opened this issue Aug 18, 2023 · 8 comments · May be fixed by #5220 or #5388
Open
1 task done

Text that convert interval seconds to days, hours, minutes, seconds #3601

bernarddt opened this issue Aug 18, 2023 · 8 comments · May be fixed by #5220 or #5388
Labels
area:dashboard The main dashboard page where monitors' status are shown area:monitor Everything related to monitors feature-request Request for new features to be added good first issue Good for newcomers help wanted May need your help to test or answer

Comments

@bernarddt
Copy link

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

UI Feature

🔖 Feature description

I would find it very useful if the GUI where you enter the intervals will also convert the interval from seconds to "days, hours, minutes and seconds" (depending if it is larger than each) and display the result under the text box like where the explanation is under the URL box, but under the interval box like here:

2023-08-18 11_33_10-Window

✔️ Solution

This just helps with monitors that are longer durations than seconds, so having an interval set to 90 will show a text like "1 Minute, 30 Seconds" or 3600 seconds will be "1 Hour, 0 Minutes, 0 Seconds".

I use large intervals that are some days or weeks apart, so having the seconds converted would help a lot to see that I'm using the correct value.

❓ Alternatives

No response

📝 Additional Context

No response
@bernarddt bernarddt added the feature-request Request for new features to be added label Aug 18, 2023
@CommanderStorm
Copy link
Collaborator

CommanderStorm commented Aug 18, 2023 •
edited
Loading

#3394 will add a similar feature to the backend.
I don't know if adding dayjs to the frontend is tolerable from a size-perspective though.

@CommanderStorm CommanderStorm added area:monitor Everything related to monitors area:dashboard The main dashboard page where monitors' status are shown labels Dec 6, 2023
@CommanderStorm CommanderStorm mentioned this issue Dec 29, 2023
Closed
1 task
@CommanderStorm CommanderStorm added help wanted May need your help to test or answer good first issue Good for newcomers labels Mar 27, 2024
@CommanderStorm
Copy link
Collaborator

image
RelativeTimeFormat.format and converting down to the best fitting unit seems like a solid choice.
Using dayjs is fine to.
The datetime mixins live here: https://github.com/louislam/uptime-kuma/blob/master/src/mixins/datetime.js

@PritamP20
Copy link

PritamP20 commented Oct 2, 2024 •
edited
Loading

I Could work on this, we should change the time show in seconds to the interval right, like min or hr, please assign to me

@Vaibhav-tech22
Copy link

Hi I would like to work on this, if it is still open. we can show time from seconds to hours/minutes that would be much more readable

@Vaibhav-tech22
Copy link

@bernarddt should this be done only for displaying the intervals or while taking the input too.

@Vivek-Py Vivek-Py linked a pull request Oct 18, 2024 that will close this issue
Open
7 tasks
@Vivek-Py
Copy link

@CommanderStorm I have raised a PR to resolve this issue.

@bernarddt
Copy link
Author

@bernarddt should this be done only for displaying the intervals or while taking the input too.

The idea is that it shows on the input screen like in the screenshot. This just help that you can see that your input is correct without having to save first. But it could show in other places as well.

@bernarddt
Copy link
Author

Sorry, not familiar with the interface 😕

@bernarddt bernarddt reopened this Oct 25, 2024
@Manavpreeet Manavpreeet linked a pull request Nov 27, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:dashboard The main dashboard page where monitors' status are shown area:monitor Everything related to monitors feature-request Request for new features to be added good first issue Good for newcomers help wanted May need your help to test or answer
Projects
None yet
Milestone
No milestone
5 participants
@bernarddt @CommanderStorm @Vivek-Py @Vaibhav-tech22 @PritamP20