Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alphabetical ordering of object properties #9

Open
ccouzens opened this issue May 6, 2021 · 3 comments
Open

alphabetical ordering of object properties #9

ccouzens opened this issue May 6, 2021 · 3 comments

Comments

@ccouzens
Copy link
Contributor

ccouzens commented May 6, 2021

It would be cool if ESLint put these keys in order alphabetically
https://github.com/loveholidays/aurora/blob/master/src/__config__/config.ts#L57-L320

@kenny-f
Copy link
Contributor

kenny-f commented May 6, 2021

There is a rule for it, but we haven't turned it on to be mandatory

@dios-david
Copy link
Contributor

we did that in horizon, but we intentionally did not move that rule to sunrise/aurora.
in most of the cases it makes more sense to group keys in a logical order instead of alphabetical

@ccouzens
Copy link
Contributor Author

ccouzens commented May 6, 2021

Maybe we turn it on selectively

https://eslint.org/docs/2.13.1/user-guide/configuring#disabling-rules-with-inline-comments

Something like:

// eslint-enable-next-line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants