diff --git a/spell/spell-crafter-mainnet-workflow.md b/spell/spell-crafter-mainnet-workflow.md index a98b1043..a43564c9 100644 --- a/spell/spell-crafter-mainnet-workflow.md +++ b/spell/spell-crafter-mainnet-workflow.md @@ -135,6 +135,10 @@ Repo: https://github.com/makerdao/spells-mainnet * [ ] Ensure good coverage (every spell action is tested) * [ ] Ensure every test function is declared as `public` * [ ] IF the test needs to run, it MUST NOT have the `skipped` modifier; OTHERWISE, it MUST have the `skipped` modifier + * IF a new module is initialized via the spell, the tests must include + * [ ] Sanity checks of the constructor arguments + * [ ] Sanity checks of all values added/updated by the spell function + * [ ] End-to-end "happy path" interaction with the module * [ ] Tests PASS via `make test` * [ ] Ensure `DssExecLib` address used in current spell (`DssExecLib.address`) matches `dss-exec-lib` [Latest Release Tag](https://github.com/makerdao/dss-exec-lib/releases/latest) * [ ] Push committed content to already opened PR diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md index a30a9c9c..2f08dc37 100644 --- a/spell/spell-reviewer-mainnet-checklist.md +++ b/spell/spell-reviewer-mainnet-checklist.md @@ -320,6 +320,10 @@ * [ ] Ensure each spell action has sufficient test coverage _List actions for which coverage was checked here_ * [ ] Ensure that any other env variable does not affect execution of the tests (for example, by inspecting the output of `printenv | grep "FOUNDRY_\|DAPP_"`) + * IF a new module is initialized via the spell, the tests must include + * [ ] Sanity checks of the constructor arguments + * [ ] Sanity checks of all values added/updated by the spell function + * [ ] End-to-end "happy path" interaction with the module * [ ] Check all tests are passing locally using `make test` * [ ] Ensure every test listed in the _coverage_ item above is present in the logs and with the `[PASS]` prefix.