From 8586bc6260be4fb57ee981182504994ef753c028 Mon Sep 17 00:00:00 2001 From: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Date: Thu, 19 Oct 2023 10:37:29 -0300 Subject: [PATCH 1/3] feat: add item regarding RWA soft liquidation --- spell/spell-reviewer-goerli-checklist.md | 28 +++++++++++------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/spell/spell-reviewer-goerli-checklist.md b/spell/spell-reviewer-goerli-checklist.md index 6bfd429b..ea1fb5e8 100644 --- a/spell/spell-reviewer-goerli-checklist.md +++ b/spell/spell-reviewer-goerli-checklist.md @@ -163,12 +163,15 @@ Spell Actions (Per Exec Sheet): * [ ] `val` price ignored (`0`) if `init` has already been called * [ ] `doc` new legal document (IPFS HASH) matches Doc (or Forum Post) * [ ] `tau` parameter used is the old `tau` value - * [ ] Autoline (`line`) + Liquidation Oracle Price Bump (`val`) - * [ ] Enable Autoline - * [ ] `ilk` follows format "RWAXXX-A" - * [ ] `line` (max debt ceiling) - * [ ] `gap` - * [ ] `ttl` + * [ ] Debt Ceiling changes (`line`) + * [ ] Autoline (`line`) + Liquidation Oracle Price Bump (`val`) + * [ ] Enable Autoline + * [ ] `ilk` follows format "RWAXXX-A" + * [ ] `line` (max debt ceiling) + * [ ] `gap` + * [ ] `ttl` + * [ ] Debt Ceiling (`line`) + Liquidation Oracle Price Bump (`val`) + * [ ] Increase Ilk Debt Ceiling (set DC + increase Global DC) * [ ] `bump` `RwaLiquidationOracle` with new computed increased price (`val`) * [ ] ensure `val` is set accordingly with autoline max debt ceiling (`line`) * [ ] `val` should enable DAI to be drawn over the loan period while taking into account the configured `ink` amount, interest rate and liquidation ratio (see below) @@ -177,15 +180,10 @@ Spell Actions (Per Exec Sheet): * [ ] Accompanying comment above `bump` line in format `// XXM * 1.XX^X * X.XX as a WAD` corresponding to the `val` calculation formula (e.g. `// 15M * 1.03^2 * 1.00 as a WAD`) is present along with the calculation formula on the line above * [ ] IF combining `val` of multiple RWA ilks being combined, `val` calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing `val` value can be retrieved by calling `read()` on `PIP_RWAXX` and converting the result into decimal. * [ ] Poke `spotter` to pull in the new price - * [ ] Debt Ceiling (`line`) + Liquidation Oracle Price Bump (`val`) - * [ ] Increase Ilk Debt Ceiling (set DC + increase Global DC) - * [ ] `bump` `RwaLiquidationOracle` with new computed increased price (`val`) - * [ ] `val` should enable DAI to be drawn over the loan period while taking into account the configured `ink` amount, interest rate and liquidation ratio (see below) - * [ ] New `val` is calculated with `line * [(1 + duty) ** years] * mat` - rounded up - and makes sense in context of the [rate mechanism](https://github.com/makerdao/developerguides/blob/master/mcd/intro-rate-mechanism/intro-rate-mechanism.md). Minimum duration is usually in the Exec Doc of the spell with the RWAXXX ilk onboarding. - * [ ] Comment explaining `val` formula (`Debt ceiling * [ (1 + RWA stability fee ) ^ (minimum deal duration in years) ] * liquidation ratio`) is present - * [ ] Accompanying comment above `bump` line in format `// XXM * 1.XX^X * X.XX as a WAD` corresponding to the `val` calculation formula (e.g. `// 15M * 1.03^2 * 1.00 as a WAD`) is present along with the calculation formula on the line above - * [ ] IF combining `val` of multiple RWA ilks being combined, `val` calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing `val` value can be retrieved by calling `read()` on `PIP_RWAXX` and converting the result into decimal. - * [ ] Poke `spotter` to pull in the new price + * [ ] Soft Liquidation (`tell`) + * [ ] Call `RwaLiquidationOracle.tell(ilk)` + * [ ] IF `RWAXXX_A_INPUT_CONDUIT` is an instance of [`TinlakeMgr`](https://github.com/centrifuge/tinlake-maker-lib/blob/master/src/mgr.sol) (it is a Centrifuge integration) + * [ ] Call `TinlakeMgr.tell()` to prevent further `TIN` redemptions in the Centrifuge pool. * [ ] Payments * [ ] Payments are not crafted or reviewed on Goerli (comments may be present) * [ ] SubDAO Content From 739e338978fbe3c2d32905ad36d44443946a8ff8 Mon Sep 17 00:00:00 2001 From: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Date: Thu, 19 Oct 2023 10:52:05 -0300 Subject: [PATCH 2/3] chore: update mainnet reviewer checklist to match goerli --- spell/spell-reviewer-goerli-checklist.md | 2 +- spell/spell-reviewer-mainnet-checklist.md | 28 +++++++++++------------ 2 files changed, 14 insertions(+), 16 deletions(-) diff --git a/spell/spell-reviewer-goerli-checklist.md b/spell/spell-reviewer-goerli-checklist.md index ea1fb5e8..57e87a0f 100644 --- a/spell/spell-reviewer-goerli-checklist.md +++ b/spell/spell-reviewer-goerli-checklist.md @@ -182,7 +182,7 @@ Spell Actions (Per Exec Sheet): * [ ] Poke `spotter` to pull in the new price * [ ] Soft Liquidation (`tell`) * [ ] Call `RwaLiquidationOracle.tell(ilk)` - * [ ] IF `RWAXXX_A_INPUT_CONDUIT` is an instance of [`TinlakeMgr`](https://github.com/centrifuge/tinlake-maker-lib/blob/master/src/mgr.sol) (it is a Centrifuge integration) + * [ ] IF `RWAXX_A_INPUT_CONDUIT` is an instance of [`TinlakeMgr`](https://github.com/centrifuge/tinlake-maker-lib/blob/master/src/mgr.sol) (it is a Centrifuge integration) * [ ] Call `TinlakeMgr.tell()` to prevent further `TIN` redemptions in the Centrifuge pool. * [ ] Payments * [ ] Payments are not crafted or reviewed on Goerli (comments may be present) diff --git a/spell/spell-reviewer-mainnet-checklist.md b/spell/spell-reviewer-mainnet-checklist.md index 940f0644..8a08491d 100644 --- a/spell/spell-reviewer-mainnet-checklist.md +++ b/spell/spell-reviewer-mainnet-checklist.md @@ -181,12 +181,15 @@ Spell Actions (Per Exec Doc): * [ ] `val` price ignored (`0`) if `init` has already been called * [ ] `doc` new legal document (IPFS HASH) matches Exec Doc * [ ] `tau` parameter used is the old `tau` value - * [ ] Autoline (`line`) + Liquidation Oracle Price Bump (`val`) - * [ ] Enable Autoline - * [ ] `ilk` follows format "RWAXXX-A" - * [ ] `line` (max debt ceiling) - * [ ] `gap` - * [ ] `ttl` + * [ ] Debt Ceiling changes (`line`) + * [ ] Autoline (`line`) + Liquidation Oracle Price Bump (`val`) + * [ ] Enable Autoline + * [ ] `ilk` follows format "RWAXXX-A" + * [ ] `line` (max debt ceiling) + * [ ] `gap` + * [ ] `ttl` + * [ ] Debt Ceiling (`line`) + Liquidation Oracle Price Bump (`val`) + * [ ] Increase Ilk Debt Ceiling (set DC + increase Global DC) * [ ] `bump` `RwaLiquidationOracle` with new computed increased price (`val`) * [ ] ensure `val` is set accordingly with autoline max debt ceiling (`line`) * [ ] `val` should enable DAI to be drawn over the loan period while taking into account the configured `ink` amount, interest rate and liquidation ratio (see below) @@ -195,15 +198,10 @@ Spell Actions (Per Exec Doc): * [ ] Accompanying comment above `bump` line in format `// XXM * 1.XX^X * X.XX as a WAD` corresponding to the `val` calculation formula (e.g. `// 15M * 1.03^2 * 1.00 as a WAD`) is present along with the calculation formula on the line above * [ ] IF combining `val` of multiple RWA ilks being combined, `val` calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing `val` value can be retrieved by calling `read()` on `PIP_RWAXX` and converting the result into decimal. * [ ] Poke `spotter` to pull in the new price - * [ ] Debt Ceiling (`line`) + Liquidation Oracle Price Bump (`val`) - * [ ] Increase Ilk Debt Ceiling (set DC + increase Global DC) - * [ ] `bump` `RwaLiquidationOracle` with new computed increased price (`val`) - * [ ] `val` should enable DAI to be drawn over the loan period while taking into account the configured `ink` amount, interest rate and liquidation ratio (see below) - * [ ] New `val` is calculated with `line * [(1 + duty) ** years] * mat` - rounded up - and makes sense in context of the [rate mechanism](https://github.com/makerdao/developerguides/blob/master/mcd/intro-rate-mechanism/intro-rate-mechanism.md). Minimum duration is usually in the Exec Doc of the spell with the RWAXXX ilk onboarding. - * [ ] Comment explaining `val` formula (`Debt ceiling * [ (1 + RWA stability fee ) ^ (minimum deal duration in years) ] * liquidation ratio`) is present - * [ ] Accompanying comment above `bump` line in format `// XXM * 1.XX^X * X.XX as a WAD` corresponding to the `val` calculation formula (e.g. `// 15M * 1.03^2 * 1.00 as a WAD`) is present along with the calculation formula on the line above - * [ ] IF combining `val` of multiple RWA ilks being combined, `val` calculation is done once per ilk and added to make the total, with workings provided in code comments. The existing `val` value can be retrieved by calling `read()` on `PIP_RWAXX` and converting the result into decimal. - * [ ] Poke `spotter` to pull in the new price + * [ ] Soft Liquidation (`tell`) + * [ ] Call `RwaLiquidationOracle.tell(ilk)` + * [ ] IF `RWAXX_A_INPUT_CONDUIT` is an instance of [`TinlakeMgr`](https://github.com/centrifuge/tinlake-maker-lib/blob/master/src/mgr.sol) (it is a Centrifuge integration) + * [ ] Call `TinlakeMgr.tell()` to prevent further `TIN` redemptions in the Centrifuge pool. * [ ] Payments * [ ] MKR transfers * [ ] Recipient addresses match Exec Doc From b19525907dd2bae4d1cc961ec6c2b0c289bc65a9 Mon Sep 17 00:00:00 2001 From: amusingaxl <112016538+amusingaxl@users.noreply.github.com> Date: Thu, 19 Oct 2023 11:11:03 -0300 Subject: [PATCH 3/3] chore: add word to spellcheck exceptions --- .wordlist.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.wordlist.txt b/.wordlist.txt index eaf97f14..b37d9cf4 100644 --- a/.wordlist.txt +++ b/.wordlist.txt @@ -138,4 +138,5 @@ PR'ed DSR setDSR multisig -EOA \ No newline at end of file +EOA +redemptions