Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel download should remove region definition #189

Open
tobrun opened this issue Dec 1, 2017 · 9 comments · May be fixed by #1145
Open

Cancel download should remove region definition #189

tobrun opened this issue Dec 1, 2017 · 9 comments · May be fixed by #1145
Labels
bug A bug is found inside the code base and should be immediately brought to attention ASAP offline-plugin Issues that deal with the offline plugin module
Milestone

Comments

@tobrun
Copy link
Member

tobrun commented Dec 1, 2017

Atm cancelling a download doesn't result in removing the created region for it. Since the download was cancelled, keeping the definition around isn't useful. You can reproduce this by downloading a region with the form, cancelling it and opening the region list activity.

@tobrun tobrun added the offline-plugin Issues that deal with the offline plugin module label Dec 1, 2017
@tobrun tobrun added this to the offline-0.1.0 milestone Dec 2, 2017
@lilykaiser lilykaiser added the bug A bug is found inside the code base and should be immediately brought to attention ASAP label Jan 29, 2018
@cammace cammace modified the milestones: offline-0.1.0, offline-0.2.0 Apr 18, 2018
@stale
Copy link

stale bot commented Oct 30, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the archived Archived by Stale bot. label Oct 30, 2018
@stale
Copy link

stale bot commented Nov 3, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 3, 2018
@djavid
Copy link

djavid commented Apr 24, 2019

As of now canceling download do not delete region.

@tobrun tobrun reopened this Apr 24, 2019
@stale stale bot removed the archived Archived by Stale bot. label Apr 24, 2019
@djavid
Copy link

djavid commented Apr 24, 2019

@tobrun Can you please see my last comment at #12382

@tobrun
Copy link
Member Author

tobrun commented Apr 24, 2019

@djavid please do not reply to closed issues, those will get unnoticed. if you find a bug or have a feature request please open a new issue instead. If you need support, please contact us at https://www.mapbox.com/contact/ or through stackoverflow. That said, please add the appropriate context and information needed to make your issue actionable for us.

@stale
Copy link

stale bot commented Oct 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot unassigned osana Oct 21, 2019
@stale stale bot added the archived Archived by Stale bot. label Oct 21, 2019
@stale
Copy link

stale bot commented Oct 21, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Oct 21, 2019
@tobrun tobrun reopened this Oct 21, 2019
@stale stale bot removed the archived Archived by Stale bot. label Oct 21, 2019
@stale
Copy link

stale bot commented Apr 18, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the archived Archived by Stale bot. label Apr 18, 2020
@stale
Copy link

stale bot commented Apr 18, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Apr 18, 2020
@langsmith langsmith reopened this Apr 20, 2020
@stale stale bot removed the archived Archived by Stale bot. label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug is found inside the code base and should be immediately brought to attention ASAP offline-plugin Issues that deal with the offline plugin module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants