Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contradiction in license Element Description for MappingSet Class #406

Open
ruihuang19 opened this issue Dec 23, 2024 · 1 comment · May be fixed by #408
Open

Contradiction in license Element Description for MappingSet Class #406

ruihuang19 opened this issue Dec 23, 2024 · 1 comment · May be fixed by #408

Comments

@ruihuang19
Copy link

In the description of the license element on https://mapping-commons.github.io/sssom/license/, it is stated as an optional element. However, in the "Induced" section at the bottom of https://mapping-commons.github.io/sssom/MappingSet/, the required property of the license element is set to true.

image
image
image
@matentzn
Copy link
Collaborator

@ruihuang19 thank you for the issue!

@sujaypatil96 I will need your help for this.

In my template I use

{% for c in gen.all_class_objects()|sort(attribute=sort_by) -%}
{% if c.name == "mapping set" %}
{{gen.link(c)}}: {{c.description|enshorten}}

| Column/Field       | Description                                             | Required    |
|--------------------|---------------------------------------------------------|-------------|
{%- for slot in c.slots %}
{%- set slot_info = schemaview.get_slot(slot) %}
| **{{ gen.link(slot) }}**     | {{ slot_info.description | default("No description") }} | {% if slot_info.required | default(false) %}Required{% elif slot_info.recommended | default(false) %}Recommended{% else %}Optional{% endif %} |
{%- endfor %}
{%- endif %}
{%- endfor %}

To show a row in the overall table. schemaview.get_slot(slot) retrieves the general information about the slot, but I want to know the information about the slot in the context for c. So license is not required in general, but in the context of the mapping set class, it is.

@matentzn matentzn linked a pull request Jan 6, 2025 that will close this issue
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure docgen uses induced slots mapping-commons/sssom
2 participants
@matentzn @ruihuang19