Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build at this moment #2

Open
cheese opened this issue Jun 12, 2018 · 1 comment
Open

Does not build at this moment #2

cheese opened this issue Jun 12, 2018 · 1 comment

Comments

@cheese
Copy link

cheese commented Jun 12, 2018

I try to build this flatpak today.
With org.gnome.Sdk set to version 3.26 and with https://github.com/endlessm/chromium-browser at commit fdb8439, the patch failed to apply:

Applying patch 0001-Fix-build-for-with-Duse_udev-0.patch
patching file chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc
Hunk #1 succeeded at 8 (offset 2 lines).
Hunk #2 FAILED at 45.
Hunk #3 succeeded at 110 with fuzz 2 (offset 3 lines).
1 out of 3 hunks FAILED -- saving rejects to file chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc.rej
patching file components/storage_monitor/storage_monitor.cc
can't find file to patch at input line 63
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/device/serial/serial_service_impl.cc b/device/serial/serial_service_impl.cc
|index 98ae1e0..ea4e2ca 100644
|--- a/device/serial/serial_service_impl.cc
|+++ b/device/serial/serial_service_impl.cc
--------------------------
File to patch:

If with the patch skipped, the build failed to begin:

LDFLAGS="-L/app/lib  -lssp" \
./build/gyp_chromium \
	-Dclang=0 \
	-Dclang_use_chrome_plugins=0 \
	-Dcomponent=shared_library \
	-Ddisable_nacl=1 \
	-Ddisable_sse2=1 \
	-Denable_hidpi=1 \
	-Denable_pepper_cdms=1 \
	-Denable_touch_ui=1 \
	-Denable_webrtc=1 \
	-Denable_widevine=1 \
	-Dlinux_dump_symbols=1 \
	-Dlinux_link_gsettings=1 \
	-Dlinux_use_bundled_binutils=0 \
	-Dlinux_use_gold_binary=0 \
	-Dlinux_use_gold_flags=0 \
	-Dlogging_like_official_build=1 \
	-Dremove_webcore_debug_symbols=1 \
	-Duse_allocator=none \
	-Duse_aura=1 \
	-Duse_gconf=0 \
	-Duse_gio=1 \
	-Duse_gnome_keyring=0 \
	-Duse_third_party_translations=0 \
	-Duse_udev=0 \
	-Dwerror= \
	--depth=`pwd`
Updating projects from gyp files...
gyp: usage: gyp_chromium [options ...] [build_file ...]

gyp_chromium: error: no build_file
make: *** [Makefile:10: all] Error 1
Error: module chromium: Child process exited with code 2
@mariospr
Copy link
Owner

This repository was created for a experiment done 2 years ago and it's not meant to be maintained, nor guaranteed to be working, as mentioned in the README file, so I'm not really surprised it failed.

Besides Chromium uses GN to build now instead of GYP at the commit you're using, so this woulr require indeed quite some work to get it working again, I'm afraid.

If you want to pick it up, or provide a patch I'd be happy to merge it, but I want to be very clear on that I don't intend to maintain this at all, it was just an experiment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants