Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade website caching system #58

Open
pivilartisant opened this issue Jul 31, 2024 · 3 comments
Open

Upgrade website caching system #58

pivilartisant opened this issue Jul 31, 2024 · 3 comments

Comments

@pivilartisant
Copy link
Collaborator

Follow up: #55 (comment)

@SlnPons
Copy link
Collaborator

SlnPons commented Jan 2, 2025

Hey @thomas-senechal could have a look at this issue & comment where it comes from and let me know the priority to address such improvement please?

@thomas-senechal
Copy link
Member

Hey @thomas-senechal could have a look at this issue & comment where it comes from and let me know the priority to address such improvement please?

This issue is a bit old and come from when we implemented the cache.

My proposal was to have a way to store some metadata related to a website. So, if a website is immutable, we know we don't need to download it again, and we don't need to resolve the MNS domain. This would also open the door to some security features around immutable websites.

IMO, as we don't "officially" support immutable websites, I don't think this issue is a priority.

@thomas-senechal
Copy link
Member

On the technical side:
I'd like to mention that we previously store zip archives of the websites. Now, we directly have each files stored in the SC. So, the DownloadDate seems irrelevant now. So the struct should look like:

type StoredWebsite struct {
	WebsiteAddress string
	Immutable      bool
	MNS            string
}

We also remade a cache system for DeWeb (here). So maybe this StoredWebsite should be used directly in the cache.

The details of the implementation still need to be discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants