Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in settings #16

Closed
wants to merge 1 commit into from
Closed

Fixed typo in settings #16

wants to merge 1 commit into from

Conversation

amittri1025
Copy link

Description

There's a error in Settings where on turning on Male Voice , female voice plays. So, I changed the name to Female Voice, now things make sense there.

image

Fixes #15

@welcome
Copy link

welcome bot commented Oct 28, 2022

Hello there! 👋 Welcome to this project! 💖
Thank you and congrats 🎉🎉 for opening your first pull request! ✨ Don't forget to star ⭐ this repo to stay updated! 😄

@vercel
Copy link

vercel bot commented Oct 28, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learning-english ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 0:01AM (UTC)

@amittri1025
Copy link
Author

kindly merge this pr with hacktoberfest label

@mathiasfc
Copy link
Owner

mathiasfc commented Oct 31, 2022

@balayokesh @amittri1025 Sorry for the delay, I had some problems here.

Guys, I think the voices of Web_Speech_API changes according to OS or device, I really don't know.

Here (Ubuntu 22), the production version works well, the voice is correct. But on my phone (Android), I had only female voices, even if male voice is enabled.

So, I need to study the API better and understand how to solve this, for now I will not accept the PR.

@amittri1025 amittri1025 closed this by deleting the head repository Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] "Male Voice: should be replaced with "Female Voice"
3 participants