-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide the number of times a particular password was pwned #4
Comments
@SeanFarrow Sounds good. Thanks. Lodge a PR and lets get it merged 👍 |
@mattevans, |
Perhaps the pwnd count could be returned as part of a new method (rather than |
I’m thinking a method such as CompromisedWithPwnedCount, how does this sound?
I’ll have a look at the tests later today
From: Matt Evans <[email protected]>
Sent: 08 March 2019 05:59
To: mattevans/pwned-passwords <[email protected]>
Cc: Sean Farrow <[email protected]>; Assign <[email protected]>
Subject: Re: [mattevans/pwned-passwords] Provide the number of times a particular password was pwned (#4)
Perhaps the pwnd count could be returned as part of a new method (rather than Compromised()). Tests are using the onsi/gomega<github.com/onsi/gomega> pkg. You can easily add tests to pwned_test.go (here<https://github.com/mattevans/pwned-passwords/blob/master/pwned_test.go> - take a look how some of the others are implemented.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#4 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABY1fqPkruqyIG8ner4Yt6xO1nzES1vEks5vUfwfgaJpZM4bf28U>.
|
It would be nice to have the number of times a password was pwned returned rather than just a true/false value as to whether it was actually pwned.
Then we could add an IsPwned method to the PwnedStore struct to allow a user to use the old behaviour if this was desired.
I'm happy to make this change if it's something you would accept?
The text was updated successfully, but these errors were encountered: