Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forced to use symfony.dev ? #58

Open
yohancourbe opened this issue Apr 13, 2017 · 8 comments
Open

forced to use symfony.dev ? #58

yohancourbe opened this issue Apr 13, 2017 · 8 comments

Comments

@yohancourbe
Copy link

I don't think it makes sense to force the use of symfony.dev. It's quite restrictive for example if you want to run multiple of this build on a server, you need to edit the config of each containers. In my opinion, the virtualhost filtering should be done by a reverse proxy, not by this container.

I would propose to

  1. rm /etc/nginx/site-available/default.conf and
  2. make symfony.conf default_server

if we want to keep this feature, it should be at least a parameter in .env

@devDzign
Copy link

UP

@yohancourbe
Copy link
Author

I'm not sure this repo is still managed..

@devDzign
Copy link

@yohancourbe ah ok, thank you

@maxpou
Copy link
Owner

maxpou commented Apr 26, 2017

Hiya @devDzign @yohancourbe,
This issue was already raise few month ago (see #6). Unfortunately, after some testing, I never find a way to do it properly. By 'properly', I mean without makesfiles&co. I want to keep this stack simple, stupid.
If you got a good way to implement it, feel free to open a pull request! I'd be more than happy to approve this!
Cheers.

@yohancourbe it is still maintained, I'm just running out of time theses days 😉

@luislard
Copy link

Yesterday I was forced to change the domain name because Chrome is forcing .dev domains to https.
I suggest to use symfony.localhost by default. More in here

@maxpou
Copy link
Owner

maxpou commented Jan 29, 2018

FYI this stack now uses symfony.local (see #90). HSTS isn't a problem anymore

@luislard
Copy link

luislard commented Jan 29, 2018 via email

@hiromik
Copy link

hiromik commented May 4, 2018

@yohancourbe assuming you run 2 complete instances of these docker-compose.yml how do you configure separately both ? I mapped port 3000 for first docker-compose on nginx and 3100 on the second but I get some sort of load balancing no matter the port, on a refresh response switches between first and second

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants