Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NRS 11 time metadata management with pbp-json-gen #13

Closed
ryjombari opened this issue May 3, 2024 · 2 comments · Fixed by #14
Closed

NRS 11 time metadata management with pbp-json-gen #13

ryjombari opened this issue May 3, 2024 · 2 comments · Fixed by #14
Assignees
Labels
bug Something isn't working

Comments

@ryjombari
Copy link
Collaborator

ryjombari commented May 3, 2024

I met with the NRS hydrophone team to confirm the standard for time metadata management. The situation is basically as follows: NRS data files are all exactly the same duration (4 hours), which is an attribute shared with our MARS data (10 minutes). However, there are real 6-7 second gaps between NRS files, in contrast to the false gaps or overlaps of 1 second cause by jitter in the seconds field of MARS data file names (caused by a glitch in Lucy software). The bottom line is that we should use the file start times in the NRS flac file names, and not attempt to fill gaps between files by nudging file start times like we do for MARS. pbp-json-gen currently puts NRS in the same category as MARS and tries to correct jitter. We want to change the logic to not do this. It should handle NRS time like it handles SoundTrap time.

@danellecline danellecline added the bug Something isn't working label May 24, 2024
@danellecline danellecline linked a pull request May 24, 2024 that will close this issue
@danellecline
Copy link
Collaborator

Relatively minor change, but I can confirm that the change works as expected.

Before

{
        "uri": "gs://noaa-passive-bioacoustic/nrs/audio/11/nrs_11_2019-2021/audio/NRS11_20191024_222253.flac",
        "start": "2019-10-24T22:22:13Z",
        "end": "2019-10-25T02:22:13Z",
        "duration_secs": 14400,
        "channels": 1
    }

After

    {
        "uri": "gs://noaa-passive-bioacoustic/nrs/audio/11/nrs_11_2019-2021/audio/NRS11_20191024_222253.flac",
        "start": "2019-10-24T22:22:53Z",
        "end": "2019-10-25T02:22:53Z",
        "duration_secs": 14400,
        "channels": 1
    }

@ryjombari
Copy link
Collaborator Author

Great. Thank you, Danelle!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants