Relative paths #21
Labels
Comments
|
Thanks for the report! |
|
@dekanex do you think you would have time creating a PR for this? |
|
What do you mean when writing PR? |
|
@dekanex change the code and send a Pull Request. No worries if you don't just thought you had had some problems and knew the fix. |
|
Hi @pomle, great work with the videos so far. I took a stab at updating the absolute paths to be relative and I've made sure that the master branch runs as expected. Could I still submit a PR for this issue and if so, which branch? |
|
Sure, let's take a look. Point it to master and I'll take a look. Can
always change that later.
Thanks!
…On 19 Feb 2018 01:36, "Eric Wong" ***@***.***> wrote:
Hi @pomle <https://github.com/pomle>, great work with the videos so far.
I took a stab at updating the absolute paths to be relative and I've made
sure that the master branch runs as expected. Could I still submit a PR for
this issue and if so, which branch?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABQTN4IsRvUdqfe4y5iN5AZQ_68V814sks5tWMIkgaJpZM4QtKb->
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Great project.
I noticed that You are using absolute paths in certain places and relative in others. I think it should be relative everywhere.
This is a list of absolute paths in files:
index.html line 18
js/loaders.js line 20
js/loaders/level.js line 37
sprites/goomba.json line 2
sprites/koopa.json line 2
sprites/mario.json line 2
sprites/overworld.json line 2
sprites/underworld.json line 2
Good luck in the project.
The text was updated successfully, but these errors were encountered: