Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the MAX7219 to test for bad data input. #4

Open
mholtrop opened this issue Mar 26, 2019 · 0 comments
Open

Update the MAX7219 to test for bad data input. #4

mholtrop opened this issue Mar 26, 2019 · 0 comments

Comments

@mholtrop
Copy link
Owner

Some routines, originally intended for internal use only but not underscored, do not check if the input is within acceptable limits. This should be tested so that programming errors are caught.

Specifically: WriteLocChar, WriteRaw, WriteInt need guards.

Also, WriteData's argument "data" is confusingly close to self.DATA. Change name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mholtrop