Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trackState from IChannel's getAttachSummary and summarize methods. #10455

Closed
NicholasCouri opened this issue May 27, 2022 · 1 comment
Closed
Assignees
Labels
ado Issue is tracked in the internal Azure DevOps backlog area: runtime: summarizer

Comments

@NicholasCouri
Copy link
Contributor

NicholasCouri commented May 27, 2022

Work Item

While adding documentation for the Summarizer in this PR: #10435 , we realized the trackState argument from IChannel is not actually required. It is currently only used for testing purposes where the context around the scenario would be ignored and the test would simply validate the summary/attachment functionality.

This work item will track down whether we can remove this trackState and automatically decided whether the
handles will be used or not. Outstanding question is how we will adjust the tests once it has been removed.

Approach
TBD

Open questions
How to fix the current tests

@ghost ghost added the triage label May 27, 2022
@NicholasCouri NicholasCouri changed the title Remove trackState from the IChannel Remove trackState from IChannel's getAttachSummary and summarize methods. May 27, 2022
@NicholasCouri NicholasCouri self-assigned this May 27, 2022
@curtisman curtisman added ado Issue is tracked in the internal Azure DevOps backlog area: runtime: summarizer and removed triage labels Jun 20, 2022
@vladsud
Copy link
Contributor

vladsud commented Jun 23, 2022

Tracked in ADO

@vladsud vladsud closed this as completed Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ado Issue is tracked in the internal Azure DevOps backlog area: runtime: summarizer
Projects
None yet
Development

No branches or pull requests

3 participants