Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Summarization to background #4912

Closed
heliocliu opened this issue Jan 25, 2021 · 4 comments
Closed

Move Summarization to background #4912

heliocliu opened this issue Jan 25, 2021 · 4 comments
Assignees
Labels
area: runtime Runtime related issues perf
Milestone

Comments

@heliocliu
Copy link
Contributor

Related to #4910

As part of the loader/container/summarizer refactoring, we should investigate moving summarization into the background by way of a webworker or similar. Once created, the summarizing client ideally should not communicate with the main client or vice versa, which simplifies the handling of the background task.

@heliocliu heliocliu added perf area: runtime Runtime related issues labels Jan 25, 2021
@heliocliu heliocliu added this to the Next milestone Jan 25, 2021
@heliocliu heliocliu self-assigned this Jan 25, 2021
@ghost ghost added the status: stale label Jul 25, 2021
@ghost
Copy link

ghost commented Jul 25, 2021

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@ghost ghost closed this as completed Aug 2, 2021
@arinwt
Copy link
Contributor

arinwt commented Aug 2, 2021

I think this is doable. Given how it currently works, the minimum information we would need would be an exchange of clientIds.

Summarizer client would like to know if its parent disconnected, so it can close itself. It could do this monitoring the Quorum, but needs to know its parent clientId.

Parent client would like to know if its spawned summarizer client disconnected/closed, so it can spawn a new one. It could also do this monitoring the Quorum, but needs to know the summarizer's JOIN seq clientId. I imagine that however we request the summarizer client, should be able to asynchronously inform the parent: (a) when it connects, giving the clientId, or (b) when it fails to connect, so that the parent doesn't need to rely on a timeout- i.e. solves "how long do we wait for our summarizer client to show up in the Quorum".

There are other ways we could implement this, but we do need some level of information exchanged between the two clients/containers so that they can ensure they are doing their best to keep a summarizer active.

@ghost ghost removed the status: stale label Aug 2, 2021
@danielroney danielroney reopened this Aug 4, 2021
@ghost ghost added the status: stale label Feb 1, 2022
@ghost
Copy link

ghost commented Feb 1, 2022

This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework!

@heliocliu
Copy link
Contributor Author

captured better in #7996

@ghost ghost removed the status: stale label Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: runtime Runtime related issues perf
Projects
None yet
Development

No branches or pull requests

3 participants