-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Summarization to background #4912
Comments
This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
I think this is doable. Given how it currently works, the minimum information we would need would be an exchange of clientIds. Summarizer client would like to know if its parent disconnected, so it can close itself. It could do this monitoring the Quorum, but needs to know its parent clientId. Parent client would like to know if its spawned summarizer client disconnected/closed, so it can spawn a new one. It could also do this monitoring the Quorum, but needs to know the summarizer's JOIN seq clientId. I imagine that however we request the summarizer client, should be able to asynchronously inform the parent: (a) when it connects, giving the clientId, or (b) when it fails to connect, so that the parent doesn't need to rely on a timeout- i.e. solves "how long do we wait for our summarizer client to show up in the Quorum". There are other ways we could implement this, but we do need some level of information exchanged between the two clients/containers so that they can ensure they are doing their best to keep a summarizer active. |
This issue has been automatically marked as stale because it has had no activity for 180 days. It will be closed if no further activity occurs within 8 days of this comment. Thank you for your contributions to Fluid Framework! |
captured better in #7996 |
Related to #4910
As part of the loader/container/summarizer refactoring, we should investigate moving summarization into the background by way of a webworker or similar. Once created, the summarizing client ideally should not communicate with the main client or vice versa, which simplifies the handling of the background task.
The text was updated successfully, but these errors were encountered: