Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As part of async summarization work, rename snapshotCore() and make it work with summaries #8013

Closed
Tracked by #7615
vladsud opened this issue Oct 27, 2021 · 0 comments · Fixed by #8592
Closed
Tracked by #7615
Assignees
Labels
refactor Code refactoring and cleanup
Milestone

Comments

@vladsud
Copy link
Contributor

vladsud commented Oct 27, 2021

Currently, SharedObject has this signature - this is what is expected from each DDS:

protected snapshotCore(serializer: IFluidSerializer): ITree;

While public API is the following, with SharedObject doing conversion:

public summarize(fullTree: boolean = false, trackState: boolean = false): ISummaryTreeWithStats;

We need to

  • remove term "snapshot" from our vocabulary
  • Remove usage of ITree in favor of ISummaryTreeWithStats, by pushing this deeper into each DDS.

This is a fork of #3929, part of #4683

Please assign to write milestone as appropriate

@vladsud vladsud added the bug Something isn't working label Oct 27, 2021
@vladsud vladsud added this to the November 2021 milestone Oct 27, 2021
@curtisman curtisman added refactor Code refactoring and cleanup and removed bug Something isn't working labels Oct 28, 2021
@scarlettjlee scarlettjlee linked a pull request Jan 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code refactoring and cleanup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants