Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what cr8 should do in AccessVpState #564

Open
cperezvargas opened this issue Dec 20, 2024 · 2 comments
Open

Figure out what cr8 should do in AccessVpState #564

cperezvargas opened this issue Dec 20, 2024 · 2 comments
Assignees
Labels
tdx TDX specific bugs or features

Comments

@cperezvargas
Copy link
Contributor

AccessVpState stubs out cr8 read/writes. Figure out if/how we should wire this up. Supposedly it's only used for the instruction emulator, which doesn't need cr8.

These error tracing calls will be downgraded to trace. There's also updates to rflags in this path

@cperezvargas cperezvargas added the tdx TDX specific bugs or features label Dec 20, 2024
@cperezvargas
Copy link
Contributor Author

For CR8 @chris-oo thinks when we fix the instruction emulator to only grab state it needs, this goes away, but we need to confirm

@smalis-msft
Copy link
Contributor

That work is happening in #482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tdx TDX specific bugs or features
Projects
None yet
Development

No branches or pull requests

3 participants