Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid multi-byte sequences cause internal file translations (to UTF8) to fail #13150

Open
Colengms opened this issue Jan 14, 2025 · 0 comments
Open

Invalid multi-byte sequences cause internal file translations (to UTF8) to fail #13150

Colengms opened this issue Jan 14, 2025 · 0 comments
Assignees
@Colengms
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service world ready An issue relating string character encodings, localization translations, etc.
Milestone
1.23.4

Comments

@Colengms
Copy link
Contributor

Colengms commented Jan 14, 2025 •
edited
Loading

Opening this to track an issue I noticed while investigating: #13078

If files.encoding is set to a multi-byte encoding, and an invalid multi-byte sequence is detected, the translation would fail. This should instead skip the invalid sequece and continue trying to translate the encoding.
@Colengms Colengms added bug Language Service world ready An issue relating string character encodings, localization translations, etc. labels Jan 14, 2025
@Colengms Colengms added this to the 1.23 milestone Jan 14, 2025
@Colengms Colengms self-assigned this Jan 14, 2025
@Colengms Colengms moved this to Pull Request in cpptools Jan 14, 2025
@sean-mcmanus sean-mcmanus modified the milestones: 1.23, 1.23.4 Jan 15, 2025
@sean-mcmanus sean-mcmanus moved this from Pull Request to Done in cpptools Jan 15, 2025
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Colengms Colengms

Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service world ready An issue relating string character encodings, localization translations, etc.
Projects
cpptools
Status: Done
Milestone
1.23.4
Development

No branches or pull requests
2 participants
@sean-mcmanus @Colengms