Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search fails to find most results, sometimes can get results if a specific file is opened #442

Open
diablodale opened this issue Apr 13, 2024 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search
Milestone

Comments

@diablodale
Copy link

diablodale commented Apr 13, 2024

Search on a remote github repo fails to find most results. No known workaround.

Setup

Version: 1.88.1 (system setup)
Commit: e170252f762678dec6ca2cc69aba1570769a5d39
Date: 2024-04-10T17:41:02.734Z
Electron: 28.2.8
ElectronBuildId: 27744544
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Windows_NT x64 10.0.22631

Name: GitHub Repositories
Id: GitHub.remotehub
Description: Remotely browse and edit any GitHub repository
Version: 0.62.0
Publisher: GitHub
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=GitHub.remotehub

Repro

  1. Run VSCode for Windows
  2. Click bottom left blue icon in bottom tray, click open remote repository, choose repo from github
  3. Paste in woocommerce/woocommerce-google-analytics-integration and select it again when prompted
  4. Verify you see the repo's files on the left. If prompted to trust, agree yes to trust.

log1.txt

  1. Click search icon in left toolbar
  2. Verify there are no files to include or exclude. Verify "only open files" is not selected.
  3. type select_content as the search term

Result

Most of the results are missing. Only two appear.
image

log2.txt

Deselecting "Use exclude settings and ignore files" does not change the result list. It continues to be errant.

Perhaps related
#175
#320

Expected

Correct is 10 results.
This is the same repo cloned locally

image

@joyceerhl
Copy link
Contributor

I'm unable to reproduce this behavior unfortunately. Which repo does this occur in so I can try to repro? When you first open the repo or run a text search, does a notification appear saying that it is downloading the repository index, and if so, does this download succeed? We rely on the downloaded index to provide accurate search results.

@joyceerhl joyceerhl added the info-needed Issue requires more information from poster label Dec 12, 2024
@joyceerhl joyceerhl self-assigned this Dec 12, 2024
@diablodale
Copy link
Author

@joyceerhl please see the repo steps in the OP. Step 3 has your answer.

@joyceerhl
Copy link
Contributor

Ah perfect, sorry I missed that! I can repro now 👍

@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug search and removed info-needed Issue requires more information from poster labels Dec 13, 2024
@joyceerhl joyceerhl added this to the January 2025 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug search
Projects
None yet
Development

No branches or pull requests

2 participants