GitHub Extension: vscode.workspace.findFiles() only covers committed files in vscode.dev

[thegecko]

Does this issue occur when all extensions are disabled?: No

• VS Code Version: 1.92.2 (VS Code for web running on vscode.dev)
• OS Version: macOS 12.4

Steps to Reproduce:

1. Open a GitHub repo in vscode.dev, e.g. https://vscode.dev/github/microsoft/vscode
2. Install an extension which utilises the vscode.workspace.findFiles() API (for the rest of these steps, use this example)
3. Execute the vscode.workspace.findFiles() function (example command: Find Files) and search with a glob (e.g. **/*.mjs) - the correct files are found
4. Create a new file in the workspace which matches the glob used in the search (e.g. temp.mjs)
5. Re-run the search and observe the results remain the same. The new file is not found.

Expected: All files in the workspace are included in the vscode.workspace.findFiles() results, not just ones under source control.

Note: this works as expected using the local filesystem in vscode.dev

[andreamah]

Does this still reproduce in https://insiders.vscode.dev/? I have made a few changes to the API since the last release, and looking at the code, I can see that it shouldn't be looking at git at all. In your case, was *.mjs in your .gitignore?

[thegecko]

Does this still reproduce in https://insiders.vscode.dev/?

Yes, I just tested this in insiders and it's still an issue

In your case, was *.mjs in your .gitignore?

No: https://github.com/microsoft/vscode/blob/main/.gitignore

[andreamah]

Is this a new regression as of 1.92.2? Or did you only notice it recently?

@joyceerhl do you know whether there is a known issue with the vscode.dev fileSearchProvider?

[thegecko]

Is this a new regression as of 1.92.2? Or did you only notice it recently?

I've only just come across this issue while developing an extension, so can't comment on whether it's a regression or not.

[thegecko]

Thanks for the transfer, will the fix be in the September release?

[joyceerhl]

You should be able to verify this fix in the current insiders.vscode.dev

[thegecko]

Thanks @joyceerhl

I tried the current insiders release and still see the issue. Notice the test.mjs file is not found:

Version: 1.93.0-insider
Commit: 4849ca9bdf9666755eb463db297b69e5385090e3
Date: 2024-09-04T13:13:15.344Z
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36

[andreamah]

@thegecko just checking- does it still not work on today's insiders?

[thegecko]

@thegecko just checking- does it still not work on today's insiders?

Still doesn't work in https://insiders.vscode.dev/github/microsoft/vscode

Version: 1.94.0-insider
Commit: c43f508b732d24b0c4732de9db2b38b4c5b88b8a
Date: 2024-09-26T05:04:07.935Z
Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/129.0.0.0 Safari/537.36

Neither staged nor uncommitted files are returned in findFiles()