Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #38402

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Dev #38402

wants to merge 13 commits into from

Conversation

abdulrahman305
Copy link

No description provided.

abdulrahman305 and others added 13 commits October 28, 2024 19:02
* Update `KNOWHERE_VERSION` to `de95`
* Update `GIT_TAG` to `de95`

Update `sed` command in `bump-version.yaml`

* Correct `sed` command to replace Milvus image tag in `deployments/docker/gpu/standalone/docker-compose.yml`

Update `bump-builder-version/action.yaml`

* Add newline at end of file
@sre-ci-robot
Copy link
Contributor

Welcome @abdulrahman305! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/compilation labels Dec 12, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abdulrahman305
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 12, 2024

@abdulrahman305 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

Copy link
Contributor

mergify bot commented Dec 12, 2024

@abdulrahman305

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@mergify mergify bot added needs-dco DCO is missing in this pull request. do-not-merge/invalid-pr-format labels Dec 12, 2024
Copy link

stale bot commented Jan 11, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation do-not-merge/invalid-pr-format needs-dco DCO is missing in this pull request. size/S Denotes a PR that changes 10-29 lines. stale indicates no udpates for 30 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants