Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: only use streaming service on e2e and nightly e2e #38743

Merged
merged 1 commit into from
Dec 26, 2024
Merged

enhance: only use streaming service on e2e and nightly e2e #38743

merged 1 commit into from
Dec 26, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Dec 25, 2024

issue: #38399

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing labels Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 25, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.32%. Comparing base (acc8fb7) to head (2727a05).
Report is 10 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (acc8fb7) and HEAD (2727a05). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (acc8fb7) HEAD (2727a05)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38743       +/-   ##
===========================================
- Coverage   81.08%   69.32%   -11.77%     
===========================================
  Files        1381      292     -1089     
  Lines      195251    26182   -169069     
===========================================
- Hits       158321    18150   -140171     
+ Misses      31345     8032    -23313     
+ Partials     5585        0     -5585
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.32% <ø> (-0.02%) ⬇️
Go ∅ <ø> (∅)

see 1090 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 25, 2024
@chyezh
Copy link
Contributor Author

chyezh commented Dec 25, 2024

rerun go-sdk

yellow-shine
yellow-shine reviewed Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@yellow-shine yellow-shine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Dec 25, 2024

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 25, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 5001878 into milvus-io:master Dec 26, 2024
9 of 12 checks passed
@chyezh chyezh deleted the use_streaming_service_for_e2e branch December 26, 2024 03:40
NicoYuan1986 pushed a commit to NicoYuan1986/milvus that referenced this pull request Dec 26, 2024
@chyezh @NicoYuan1986
enhance: only use streaming service on e2e and nightly e2e (milvus-io…
930bfd1 
…#38743)

issue: milvus-io#38399

Signed-off-by: chyezh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yellow-shine yellow-shine yellow-shine left review comments

@sunby sunby Awaiting requested review from sunby

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@yanliang567 yanliang567

@yellow-shine yellow-shine

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chyezh @yanliang567 @sre-ci-robot @yellow-shine