Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.5] fix restore rbac empty meta crash #39143

Open
wants to merge 1 commit into
base: 2.5
Choose a base branch
from

Conversation

shaoting-huang
Copy link
Contributor

cp from master: #39141
related: #38985

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shaoting-huang
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/S Denotes a PR that changes 10-29 lines. labels Jan 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 10, 2025
Copy link
Contributor

mergify bot commented Jan 10, 2025

@shaoting-huang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.55%. Comparing base (95809ca) to head (4b7ca95).
Report is 4 commits behind head on 2.5.

❗ There is a different number of reports uploaded between BASE (95809ca) and HEAD (4b7ca95). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (95809ca) HEAD (4b7ca95)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #39143       +/-   ##
===========================================
- Coverage   81.02%   69.55%   -11.48%     
===========================================
  Files        1389      294     -1095     
  Lines      196343    26460   -169883     
===========================================
- Hits       159091    18403   -140688     
+ Misses      31629     8057    -23572     
+ Partials     5623        0     -5623     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.55% <ø> (+<0.01%) ⬆️
Go ∅ <ø> (∅)

see 1096 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 10, 2025
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Jan 11, 2025
@mergify mergify bot removed the ci-passed label Jan 11, 2025
@shaoting-huang
Copy link
Contributor Author

rerun ut

Copy link
Contributor

Hello shaoting-huang, you are not in the organization, so you do not have the permission to rerun the workflow, please contact @milvus-io/milvus-maintainers for help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test dco-passed DCO check passed. kind/bug Issues or changes related a bug sig/testing size/M Denotes a PR that changes 30-99 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants