Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Setting async_client = false does not work properly when enable_custom_operations = true. #303

Closed
Tracked by #302
huy-d-nguyen opened this issue Jul 18, 2024 · 2 comments · Fixed by #304
Closed
Tracked by #302
Labels

Comments

@huy-d-nguyen
Copy link

Hello,

It appears that our recent feature, enable_custom_operations, is not functioning correctly when we set async_client = false. Although the BaseClient is the synchronous version, the generated client is improperly using async def for its functions (e.g., async def query & async def mutation) when it should be using normal def.

image
@DamianCzajkowski
Copy link
Contributor

Hi,

Yes, I am aware of this issue. In the first iteration, I did not plan to make custom operations compatible with async_client = false. This is not a bug; it is a feature that still needs to be implemented.

Thank you for pointing it out though! If you would like to contribute to this issue, please prepare a pull request for me to review and merge. Thanks!

@huy-d-nguyen
Copy link
Author

Thank you for your effort, it's much appreciated. Sorry I was too busy to help, but I hope to have a chance to lend a hand in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants