Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/style: adjusted the primary buttons position #976

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

BenniEngel
Copy link
Member

adjusted the primary buttons position if it is the only one in the action group

@BenniEngel BenniEngel linked an issue Nov 15, 2024 that may be closed by this pull request
@BenniEngel BenniEngel self-assigned this Nov 15, 2024
Copy link
Contributor

github-actions bot commented Nov 15, 2024

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 29.08% 4242 / 14585
🔵 Statements 29.08% 4242 / 14585
🔵 Functions 32.84% 226 / 688
🔵 Branches 56.54% 484 / 856
File CoverageNo changed files found.
Generated in workflow #1779 for commit 115bd94 by the Vitest Coverage Report Action

Copy link
Member

@mfal mfal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not work, if there are additional secondary buttons.

See Section "Zusätzlicher Secondary Button" in Style Guide.

@mfal mfal merged commit 003da76 into main Nov 27, 2024
4 checks passed
@mfal mfal deleted the 971-wrong-position-of-primary-buttons-in-actiongroup branch November 27, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong position of primary Buttons in ActionGroup
3 participants