Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(List): add option to toggle list details #991

Merged
merged 1 commit into from
Nov 19, 2024
Merged

feat(List): add option to toggle list details #991

merged 1 commit into from
Nov 19, 2024

Conversation

mfal
Copy link
Member

@mfal mfal commented Nov 19, 2024

No description provided.

@mfal mfal linked an issue Nov 19, 2024 that may be closed by this pull request
Expandable List Item #984
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024 •
edited
Loading

Coverage Report for ./packages/components/

Status Category Percentage Covered / Total
🔵 Lines 29.1% 4281 / 14710
🔵 Statements 29.1% 4281 / 14710
🔵 Functions 32.85% 227 / 691
🔵 Branches 56.44% 486 / 861
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/components/src/components/List/components/Items/components/Item/Item.tsx 94.87% 37.5% 100% 94.87% 25-26
packages/components/src/components/List/components/Items/components/Item/components/AccordionButton.tsx 28% 100% 0% 28% 18-38
packages/components/src/components/List/components/Items/components/Item/components/View/View.tsx 92.64% 100% 50% 92.64% 20-24
packages/components/src/components/List/components/Items/components/Item/hooks/useGridItemProps.tsx 43.75% 40% 33.33% 43.75% 29-31, 38-39, 45-79
packages/components/src/components/List/model/List.ts 65.06% 64.7% 46.66% 65.06% 71, 74, 101-110, 118-122, 133-151, 154-161, 165-170, 174-177, 180-181, 184-185, 188-189
packages/components/src/components/List/model/types.ts 100% 100% 100% 100%
packages/components/src/components/List/model/item/ItemView.ts 92.3% 80% 80% 92.3% 34, 39
packages/components/src/components/List/stories/Default.stories.tsx 0% 0% 0% 0% 1-220
Generated in workflow #1789 for commit 1bc22a4 by the Vitest Coverage Report Action

@mfal mfal force-pushed the 984-expandable-list-item branch from 0202e22 to 783efef Compare November 19, 2024 10:55
@mfal mfal temporarily deployed to github-pages-preview-storybook November 19, 2024 10:56 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview November 19, 2024 10:56 — with GitHub Actions Inactive
@mfal mfal force-pushed the 984-expandable-list-item branch from 783efef to 24de7de Compare November 19, 2024 10:57
@mfal mfal temporarily deployed to github-pages-preview November 19, 2024 10:57 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview-storybook November 19, 2024 10:57 — with GitHub Actions Inactive
@mfal mfal force-pushed the 984-expandable-list-item branch from 24de7de to 74216c6 Compare November 19, 2024 12:03
@mfal mfal temporarily deployed to github-pages-preview November 19, 2024 12:03 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview-storybook November 19, 2024 12:03 — with GitHub Actions Inactive
@mfal mfal force-pushed the 984-expandable-list-item branch from 74216c6 to 00cc152 Compare November 19, 2024 12:04
@mfal mfal temporarily deployed to github-pages-preview November 19, 2024 12:04 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview-storybook November 19, 2024 12:04 — with GitHub Actions Inactive
@mfal mfal force-pushed the 984-expandable-list-item branch from 00cc152 to 1bc22a4 Compare November 19, 2024 12:12
@mfal mfal temporarily deployed to github-pages-preview November 19, 2024 12:12 — with GitHub Actions Inactive
@mfal mfal temporarily deployed to github-pages-preview-storybook November 19, 2024 12:12 — with GitHub Actions Inactive
@mfal mfal merged commit cf7075a into main Nov 19, 2024
4 checks passed
@mfal mfal deleted the 984-expandable-list-item branch November 19, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lisa18289 Lisa18289 Lisa18289 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expandable List Item
2 participants
@mfal @Lisa18289