Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refatoring -- ws 2023 discussion with john, seb, bb #37

Open
berndbischl opened this issue Aug 26, 2023 · 3 comments
Open

refatoring -- ws 2023 discussion with john, seb, bb #37

berndbischl opened this issue Aug 26, 2023 · 3 comments

Comments

@berndbischl
Copy link
Member

bmr = benchmark(....)

bma = as_benchmark_aggr(bmr)
bms = as_benchmark_score(bmr)
bml = as_benchmark_loss(bmr)

friedman / blme

autoplot(bma) ---> plots without tests: mean, box

  • we remove type = "mean", useless worse version of a boxplot
  • boxplots "accross tasks" MAYBE MAYBE ok SOMETIMES, but we also want task-facetting

infer_friedman_global(bma, measure) --> s3: (friedman_global, infer)

infer_friedman_posthoc(bma, measure, global = T/F) --> s3: (friedman_posthoc, infer)

autoplot.friedmanpostdoc(ifp, type = c("cd", "fn")) ----------> does CD plot
comment:
we keep the posthoc-matrix plot
only keep one CD plot, MAYBE have some MILD, SIMPLE args to configure its style

infer_blme: similar as above....!


we probably want some form of standardization if we have multiple tasks

  • average distance to the minimum
  • 0 should represent the perf of a "baseline". eg the featureless learner
  • (y - ymin) / (ymin - ymax). also think about r_squared like versions
@berndbischl
Copy link
Member Author

containers support multiple measures
plots and tests support 1 measure. if none is passed we use the first one in the container

@berndbischl
Copy link
Member Author

infer_blme(bms) --> (blme, infer)
autoplot(iblme, type = "ridgeline", "interval", "halfeye")

@berndbischl
Copy link
Member Author

maybe add (exposed) helper that draws from the posterior of the BLME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant