New PipeOpEncodePL for Piecewise Linear Encoding
#861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advieser
commented
Dec 21, 2024
| private$.tree_learner = LearnerClassifRpart$new() | ||
| } else { | ||
| stopf("Task type %s not supported", task_type) | ||
| } |
There was a problem hiding this comment.
Don‘t need task_type if we use method = "quantiles", meaning that we should only check this in that case and don‘t throw an error, etc. We could set task type as "Task" by default …
However, mlr_reflections$task_types does not contain this as an acceptable name, so change the assert.
advieser
commented
Dec 21, 2024
| t = task$clone(deep = TRUE)$select(col) | ||
| splits = learner$train(t)$model$splits | ||
| # Get column "index" in model splits | ||
| boundaries = unname(sort(splits[, "index"])) |
There was a problem hiding this comment.
Can simplify this into one line now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #813