-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not fit transformers on testing data #3818
Comments
Moving transformers that require fitting to the clf pipeline could fix the leaking issue: bugbug/bugbug/models/defect.py Lines 313 to 341 in 49e79c8
However, with this solution, the extraction pipeline can no longer be treated as a transformers pipeline (transformers should support |
The ideal solution for now will be to have two pipelines, one for extracting, and one for transforming. The extraction pipeline should not allow using |
Currently, we fit the transformers before splitting the data, which could leak testing data into the training data, especially when using something like TF-IDF in the extraction pipeline:
Transforming:
bugbug/bugbug/model.py
Line 352 in 02906a6
Splitting:
bugbug/bugbug/model.py
Line 368 in 02906a6
The text was updated successfully, but these errors were encountered: