Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code_review] Filter out praise comments #4324

Closed
marco-c opened this issue Jul 10, 2024 · 0 comments · Fixed by #4405
Closed

[code_review] Filter out praise comments #4324

marco-c opened this issue Jul 10, 2024 · 0 comments · Fixed by #4405
Assignees
@olewicki
Labels
code-review

Comments

@marco-c
Copy link
Collaborator

marco-c commented Jul 10, 2024

We have received feedback that the tool is generating praise comments ("this refactoring makes things clearer, etc."), which are acceptable when coming from human reviewers, but don't make much sense when coming from a bot.
@marco-c marco-c changed the title Filter out praise comments in the Code Review tool [code_review] Filter out praise comments Aug 7, 2024
@marco-c marco-c linked a pull request Aug 7, 2024 that will close this issue
Code review prompt update #4405
Merged
@marco-c marco-c closed this as completed in 1ac170f Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olewicki olewicki

Labels
code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code review prompt update mozilla/bugbug
3 participants
@marco-c @suhaibmujahid @olewicki