Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip, PreviewCard] Use FloatingPortalLite #1278

Merged
merged 2 commits into from
Jan 8, 2025
Merged

[Tooltip, PreviewCard] Use FloatingPortalLite #1278

merged 2 commits into from
Jan 8, 2025
+24 −4

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Jan 2, 2025 •
edited
Loading

Part of #1246. Depends on refactors made in #1222

This prevents bringing in tabbable logic (tabbable dependency and extra code from Floating UI) if just importing the Tooltip or PreviewCard components, saving bundle size

@atomiks atomiks added component: tooltip This is the name of the generic UI component, not the React module! component: preview card The React component. labels Jan 2, 2025
@mui-bot
Copy link

mui-bot commented Jan 2, 2025 •
edited
Loading

Netlify deploy preview

https://deploy-preview-1278--base-ui.netlify.app/

Generated by 🚫 dangerJS against 077387c

@atomiks atomiks force-pushed the feat/floating-portal-lite branch from 6a6c05d to 077387c Compare January 7, 2025 11:15
@atomiks atomiks marked this pull request as ready for review January 7, 2025 11:19
michaldudak
michaldudak approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Side note: I'd appreciate it if you could write more verbose PR descriptions, so in a year from now, it's easier to figure out why a particular piece of code was added.

@atomiks
Copy link
Contributor Author

atomiks commented Jan 8, 2025

@michaldudak updated description

@atomiks atomiks merged commit 31cea62 into mui:master Jan 8, 2025
23 checks passed
@atomiks atomiks deleted the feat/floating-portal-lite branch January 8, 2025 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

@colmtuite colmtuite Awaiting requested review from colmtuite colmtuite is a code owner

Assignees
No one assigned
Labels
component: preview card The React component. component: tooltip This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atomiks @mui-bot @michaldudak