Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Link h2 and h3 in docs #1302

Closed
wants to merge 2 commits into from

Conversation

mj12albert
Copy link
Member

Closes #1181

@mj12albert mj12albert added the docs Improvements or additions to the documentation label Jan 8, 2025
@mui-bot
Copy link

mui-bot commented Jan 8, 2025

Netlify deploy preview

https://deploy-preview-1302--base-ui.netlify.app/

Generated by 🚫 dangerJS against fd31f33

@mj12albert
Copy link
Member Author

mj12albert commented Jan 8, 2025

Dunno if it's a bit much, but I made the icon always show for touch devices, none of the examples I looked at looked obviously like links to me

heading-link.mp4

@mj12albert mj12albert marked this pull request as ready for review January 8, 2025 08:37
@colmtuite
Copy link
Contributor

Closing this for now because we'll need some time to consider whether to add this, and if so, how to handle it.

It's possible that only the icon should be inside <a>. It will also need text-underline-offset, different colors, and a larger icon etc. It will be better to batch docs improvements.

@colmtuite colmtuite closed this Jan 8, 2025
@mj12albert mj12albert deleted the docs/heading-link branch January 9, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Headings should be linkable
3 participants