Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Translation Feature Request for Media Chrome (React) #1028

Open
peter-neumann-dev opened this issue Nov 22, 2024 · 1 comment
Open

Comments

@peter-neumann-dev
Copy link

Currently, there's no official way to translate the default labels in media-chrome/labels/labels. While we've implemented a workaround using Object.assign in our Next.js/React application, this solution has several drawbacks:

Current Issues

  • The Object.assign approach is cumbersome to maintain
  • Experiencing loading and caching issues with this implementation
  • No clear way to handle dynamic language changes

Feature Request

Could we implement an official way to handle label translations? Possible solutions could include:

  • A dedicated prop for label translations
  • A translation hook or utility function
  • A configuration option in the component's setup

This would greatly improve the developer experience and make the library more internationalization-friendly.

Current Workaround

Object.assign(mediaChrome.labels, translatedLabels);

Thank you 🙏🏻😊 for maintaining this great library! We appreciate your consideration of this feature request and are happy to provide any additional information or use cases if needed.

@luwes
Copy link
Contributor

luwes commented Dec 4, 2024

thanks for the feedback! this is on our radar and will improved in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants