Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Media-Time-Range scrub and skimming is broken if video is not pre-loaded, happens often on iOS 17.5 #910

Open
jelias opened this issue May 14, 2024 · 2 comments
Open

Media-Time-Range scrub and skimming is broken if video is not pre-loaded, happens often on iOS 17.5 #910

jelias opened this issue May 14, 2024 · 2 comments
Assignees
@luwes

Comments

@jelias
Copy link

jelias commented May 14, 2024

just ran into another bug? seems that the media-time-range scrub and skimming is broken with the latest iOS update? Running iOS 17.5. It looks like it skims and updates, but one play it reverts back to the original playhead position?
Seems to be only an issue before the video starts play. And leaves the UI timecode vulnerable to being completely out of sync and just wrong

Some further research and testing from my end, it seems to happen most frequently when the video hasn't started loading for some reason.

You can see it happen even on desktop in the media-chrome examples:
https://media-chrome.mux.dev/examples/vanilla/state-change-events-demo.html

  1. Try to scrub
  2. Hit play
  3. Notice scrub goes back to 0.
@jelias
Copy link
Author

jelias commented May 14, 2024

and to confirm, you weren't seeing this in iOS previously??

correct. in prior iOS versions this was not an issue. my guess is some sort of bug between loading the video player and the browser not letting it happen?

@luwes luwes added the bug Something isn't working label Sep 19, 2024
@luwes luwes self-assigned this Sep 25, 2024
luwes added a commit to luwes/media-chrome that referenced this issue Oct 4, 2024
@luwes
fix: seeking when preload is none
25fe3fc 
fix muxinc#910
@luwes luwes mentioned this issue Oct 4, 2024
Merged
luwes added a commit to luwes/media-chrome that referenced this issue Oct 4, 2024
@luwes
fix: seeking when preload is none
9794ad1 
fix muxinc#910
luwes added a commit that referenced this issue Oct 4, 2024
@luwes
fix: seeking when preload is none (#997)
5000cc3 
related #910

this fixes an issue where when you seek before the video is loaded we
don't set the video.currentTime.

it's fine to set the currentTime anytime. it doesn't throw for a valid
number value.
but users have to set the `defaultduration` in some cases. not sure with
iOS and native HLS.
@luwes
Copy link
Contributor

luwes commented Oct 8, 2024

This has at least been partly fixed. We've successfully tested it on desktop and iOS 17 physical device.
On iOS 18 via Browserstack it was not working.

@luwes luwes removed the bug Something isn't working label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luwes luwes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luwes @jelias