Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{no_ack, false} not implemented #15

Open
ypaq opened this issue Jan 23, 2013 · 4 comments
Open

{no_ack, false} not implemented #15

ypaq opened this issue Jan 23, 2013 · 4 comments

Comments

@ypaq
Copy link

ypaq commented Jan 23, 2013

Hey Brian,

I was looking through the code and couldn't find a way to explicitly acknowledge messages. Am I missing something or is there no way implemented to ack messages with gen_qserver/gen_qfsm?

Cheers

  • Tilman
@muxspace
Copy link
Owner

Tilman,

Correct, there is nothing in bunny_farm to explicitly acknowledge messages. Shouldn't be hard to build that in or just acknowledge from your gen_qserver/gen_qfsm behavior.

Brian

On Jan 22, 2013, at 7:07 PM, ypaq wrote:

Hey Brian,

I was looking through the code and couldn't find a way to explicitly acknowledge messages. Am I missing something or is there no way implemented to ack messages with gen_qserver/gen_qfsm?

Cheers

  • Tilman


Reply to this email directly or view it on GitHub.

@ypaq
Copy link
Author

ypaq commented Jan 24, 2013

In order to enable {no_ack, false} bunny_farm needs some changes. bunny_farm:consume will always use {no_ack, true} (see https://github.com/muxspace/bunny_farm/blob/master/src/bunny_farm.erl#L80). You need to allow to subscribe accordingly. Just ack from somewhere else won't cut it.

@muxspace
Copy link
Owner

Good catch. It's still an easy change. You're welcome to submit a pull request if you implement this.

On Jan 24, 2013, at 3:58 PM, ypaq wrote:

In order to enable {no_ack, false} bunny_farm needs some changes. bunny_farm:consume will always use {no_ack, true} (see https://github.com/muxspace/bunny_farm/blob/master/src/bunny_farm.erl#L80). You need to allow to subscribe accordingly. Just ack from somewhere else won't cut it.


Reply to this email directly or view it on GitHub.

@ypaq
Copy link
Author

ypaq commented Jan 24, 2013

Will see if I find the time. I decided to go with gen_bunny because of its monitoring. I like your clean code and the exhaustive tests though. Good job on your bunny_farm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants