Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Treesitter highlight groups #86

Open
ilAYAli opened this issue Feb 3, 2021 · 8 comments
Open

Support Treesitter highlight groups #86

ilAYAli opened this issue Feb 3, 2021 · 8 comments

Comments

@ilAYAli
Copy link

ilAYAli commented Feb 3, 2021

Support for Treesitter highlight groups would be much appreciated:

TSError
TSPunctDelimiter
TSPunctBracket
TSPunctSpecial
TSConstant
TSConstBuiltin
TSConstMacro
TSStringRegex
TSString
TSStringEscape
TSCharacter
TSNumber
TSBoolean
TSFloat
TSAnnotation
TSAttribute
TSNamespace
TSFuncBuiltin
TSFunction
TSFuncMacro
TSParameter
TSParameterReference
TSMethod
TSField
TSProperty
TSConstructor
TSConditional
TSRepeat
TSLabel
TSKeyword
TSKeywordFunction
TSKeywordOperator
TSOperator
TSException
TSType
TSTypeBuiltin
TSStructure
TSInclude
TSVariable
TSVariableBuiltin
TSText
TSStrong
TSEmphasis
TSUnderline
TSTitle
TSLiteral
TSURI
TSTag
TSTagDelimiter
TSNone
TSQueryLinterError
@onsails
Copy link

onsails commented Feb 8, 2021

plus LspReferenceRead, LspReferenceWrite, LspReferenceText

@markstos
Copy link

markstos commented Apr 6, 2021

Another developer has ported Jellybeans to Treesitter: https://github.com/metalelf0/jellybeans-nvim

@naquad
Copy link

naquad commented Feb 16, 2022

I second this request. The referenced port has no TS support.

@bellini666
Copy link

To anyone here, https://github.com/ThemerCorp/themer.lua has added support for jellybeans a while ago.

I'm using it and is working very well! It has already integration with most of the popular plugins out there (e.g. Treesitter, LSP, Telescope, Lualine, etc) and is really easy to override some colors for personal preference. Just setup it with jellybeans colorscheme and you are done!

For example, I override some colors to have a darker PMenu (which is also used by nvim-cmp), which in my opinion looks nicer.

@naquad
Copy link

naquad commented Feb 16, 2022

@bellini666 could you please show a screenshot of your theme?

@bellini666
Copy link

@naquad sure! Here are some examples, with python and lua code (obs. the PMenu from the completion in one of them is the one I override for customization. The rest is directly from themer)

Screenshot from 2022-02-16 16-44-35
Screenshot from 2022-02-16 16-43-34
Screenshot from 2022-02-16 16-43-22

@markstos
Copy link

I compared the highlighting this jellybeans colorsceme to themer_jellybeans. There some minor differences.

The most obvious is the highlight column used to color the 100th column. There is another differences which might be due to treesitter-related colorining. Notice that b:dispatch and test#strategy have changed colors

With jellybeans theme

image

With themer_jellybeans

image

@markstos
Copy link

I submitted a PR to fix the ColorColumn difference and a visual select difference in Themer, but also found a couple other differences with it:

ThemerCorp/themer.lua#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants