From b1067243e6b18797a6a8560f5ed26d95305bb7ff Mon Sep 17 00:00:00 2001 From: "R.I.Pienaar" Date: Wed, 30 Oct 2024 13:41:59 +0100 Subject: [PATCH] Compact the versioning metadata Also remove some unused information in ADR-43 Signed-off-by: R.I.Pienaar --- adr/ADR-43.md | 13 ------------- adr/ADR-44.md | 12 +++++------- 2 files changed, 5 insertions(+), 20 deletions(-) diff --git a/adr/ADR-43.md b/adr/ADR-43.md index ec79554..69506ef 100644 --- a/adr/ADR-43.md +++ b/adr/ADR-43.md @@ -52,19 +52,6 @@ The `Nats-Limit-Applied` field is there to support future expansion of this feat This behaviour is off by default unless opted in on the Stream Configuration. -## Publish Acknowledgements - -We could optionally extend the `PubAck` as follows: - -```golang -type PubAck struct { - MsgTTL uint64 `json:"msg_ttl,omitempty"` -} -``` - -This gives clients a chance to confirm, without Stream Info or should the Stream be edited after Info, if the TTL -got applied. - ## Stream Configuration Weather or not a stream support this behavior should be a configuration opt-in. We want clients to definitely know diff --git a/adr/ADR-44.md b/adr/ADR-44.md index c0cf30e..ed66795 100644 --- a/adr/ADR-44.md +++ b/adr/ADR-44.md @@ -109,13 +109,11 @@ API level only needs to be incremented once and not for every new feature. We'll store current server and asset related information in the existing `metadata` field allowing us to expand this in time, today we propose the following: -| Name | Description | -|----------------------------------|-----------------------------------------------------------| -| `_nats.server.version` | The current server version hosting an asset | -| `_nats.server.api_level` | The current server API level hosting an asset | -| `_nats.server.require.api_level` | The required API level to start an asset | -| `_nats.created.server.version` | The version of the server that first created this asset | -| `_nats.created.server.api_level` | The API level of the server that first created this asset | +| Name | Description | +|-------------------|-----------------------------------------------| +| `_nats.ver` | The current server version hosting an asset | +| `_nats.level` | The current server API level hosting an asset | +| `_nats.req.level` | The required API level to start an asset | We intend to store some client hints in here to help us track what client language and version created assets.