Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent handling of \r in protocol parser #6369

Open
neilalexander opened this issue Jan 13, 2025 · 0 comments
Open

Inconsistent handling of \r in protocol parser #6369

neilalexander opened this issue Jan 13, 2025 · 0 comments
Labels
defect Suspected defect such as a bug or regression

Comments

@neilalexander
Copy link
Member

Observed behavior

The handling of \r characters is not always consistent when they don't follow a \n. The behaviour here is different depending on whether we're using argBuf or not, and can cause unrelated characters to be dropped from the bytestring in some cases.

Pedantic mode avoids this issue somewhat, but it can result in unexpected \r characters being propagated which could cause a connection to be dropped.

Expected behavior

Better checking for characters other than \n when drop is set in the parser.

Server and client version

All

Host environment

No response

Steps to reproduce

No response

@neilalexander neilalexander added the defect Suspected defect such as a bug or regression label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Suspected defect such as a bug or regression
Projects
None yet
Development

No branches or pull requests

1 participant