Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose withCredentials param and don't set to true by default #29

Closed
gsf opened this issue Jun 26, 2014 · 2 comments
Closed

Expose withCredentials param and don't set to true by default #29

gsf opened this issue Jun 26, 2014 · 2 comments

Comments

@gsf
Copy link
Collaborator

gsf commented Jun 26, 2014

See relevant conversations at browserify/http-browserify#35 and browserify/http-browserify#47.
@Raynos
Copy link
Collaborator

Raynos commented Jun 26, 2014

👍

@Raynos
Copy link
Collaborator

Raynos commented Jun 26, 2014

Will accept patch.

@gsf gsf mentioned this issue Jul 1, 2014
Merged
gsf pushed a commit to gsf/xhr that referenced this issue Jul 1, 2014
True by default when cors is true. naugtur#29
b2a49ce
@Raynos Raynos closed this as completed in 62ccd95 Jul 1, 2014
Raynos added a commit that referenced this issue Jul 1, 2014
@Raynos
Merge pull request #33 from gsf/withCredentials-option
58e4e30 
Add withCredentials option. Fix #29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gsf @Raynos