-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trajectory not updating after loading a save with/while a vessel is in atmosphere. #189
Comments
@Janus1992 Does this happen when loading in a save file while there is a craft in the air and/or the save file has a craft in the air ? A log file would be handy to see, start a new game then perform the actions needed, then exit as soon as possible to keep the log to a minimum. Install this debug version before you take logs it will provide more details ;) |
@PiezPiedPy Exactly, this happens mostly when the craft is in the air. I already noticed some differences in the behaviour between a number of ksp sessions. There was a difference from session 1-4, and session 5: Session 1 (also: 2, 3 and 4 are equal to this one):
Session 5:
Other than those differences there are no differences in the ksp.log (I checked them sentence by sentence for every sentence with 'trajectories' in it). As far as I can see there is no log message for an auto-update happening. Sometimes it auto-updates, sometimes not. |
@Janus1992 Thx for the info, Auto-update triggers the cache initialization which appears to be executed. I'll need to have a deeper look. |
@Janus1992 Are you still getting the same issue using v2.4.4 ? |
It sounds similar indeed. I am also getting it in 2.4.4, but like before, it only happens sometimes. Last time it happened after I loaded a ship in the duna atmosphere, while the save I opened before was a kerbin atmo save. But I can't discover a pattern yet. |
@Janus1992 Are you using a mod that loads saves the game rather than the stock menu save and load ? |
No to both! I keep the game as much stock as possible, except for the starship needs. Although this behaviour was already happening when I was still making pure stock starships. |
Would it be possible to implement a kOS call I can make to manually update the trajectory from the script? This would perhaps be the most simple solution/work around for the issue. |
As mentioned before the update method is being called as it should due to its output showing in the log, calling the API manually will not help in this case. I believe the problem to be in the display of the trajectory rather than the computation. The API call would need to be implemented into the kOS code base not here in Trajectories. It would also require the kOS developers to release an updated version of kOS that included the needed functionality. |
Trajectory not updating after loading a save with a vessel in atmosphere
Seems the issue was due to a vessel still being packed while the aero model was initializing. Hopefully now fixed. |
Thanks a lot for the help and the explanation on kOS! I will try the latest repository updates out when I have some time in a few days. |
In reference to this post:
https://forum.kerbalspaceprogram.com/index.php?/topic/162324-18-112x-trajectories-v241-2021-06-27-atmospheric-predictions/&do=findComment&comment=4148297
There is currently no way to trigger an aerodynamic update via kOS.
This would only be a workaround, as the real bug seems to be unreliable/intermittent auto-updating from within Trajectories, which causes differences in the result when 'update' is pressed.
The text was updated successfully, but these errors were encountered: