Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predict air brakes #58

Open
neuoy opened this issue Sep 4, 2015 · 8 comments
Open

Predict air brakes #58

neuoy opened this issue Sep 4, 2015 · 8 comments

Comments

@neuoy
Copy link
Owner

neuoy commented Sep 4, 2015

Both stock brakes and other mods. Use the current state of brakes (even if the ship is still in space) to know if they will be deployed during entry or not.

@fat-lobyte fat-lobyte modified the milestone: probably-never May 1, 2017
@fat-lobyte
Copy link
Collaborator

Question to the community: Is this even relevant, or should I close this?

The thing is, air brakes are not useful for reentry anymore because they will burn right off in the flaming ball of plasma when deployed.

I think the "support" for air brakes should be limited to them being calculated correctly in the state that they are currently in (or rather that the aerodynamic model is based on), and not on a future deploying point.

@PiezPiedPy
Copy link
Contributor

Maybe an airbrake deploy altitude value that can be set by the user in the Gui Descent Profile would be useful.

@fat-lobyte
Copy link
Collaborator

Maybe an airbrake deploy altitude value that can be set by the user in the Gui Descent Profile would be useful.

I guess, but that's again a change of the vessel state in the future that we can't yet simulate. Right now we take the vessel as-is, and simulate all the forces on it from all kinds of directions and speeds.

Doing changes of the vessel state in the future requires some changes in the way that we request forces in the future. That's kind of also the reason why we can't predict with parachute deployments and staging.

@PiezPiedPy
Copy link
Contributor

Thanks for explaining, I've not looked at any of the simulation code yet, so I didn't really have a clue if it would work or not, ahh well

@fat-lobyte
Copy link
Collaborator

According to a forum user, Current state of air brakes is not used for drag calculations.

I will need to test, and then figure out why they are not considered.

@fat-lobyte
Copy link
Collaborator

Turns out the code in StockAeroUtil.SimAeroForce() that is supposed to handle wings and such doesn't do much when it comes to Airbrakes.

I will take a look at that at some point.

@PiezPiedPy
Copy link
Contributor

PiezPiedPy commented Mar 14, 2021

I might be able to do something about this issue if the Multithreading #123 gets finished.

Since a lot of data is cached for thread safety, including the drag cubes as well as the math for aero calculations it should be possible to swap drag cubes etc as needed.

A simple list that can be changed on the GUI or a widget on a parts info panel should be sufficient for deployment altitude etc.

@PiezPiedPy PiezPiedPy added bug and removed bug labels Mar 24, 2021
@mwerle
Copy link
Contributor

mwerle commented Jul 5, 2021

Maybe show the impact point with and without air brakes deployed.. since the mod can't know when they will be deployed, by showing impact markers for both situations, the pilot can guestimate where they will land since it will be between the two points depending on when the brakes are deployed?

As for me, my air brakes (Kerbin orbital velocity reentry) don't burn off during reentry.. I deploy them after my reentry burn before hitting any atmosphere.

@PiezPiedPy PiezPiedPy removed their assignment Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants