Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cannot import neurodsp.timefrequency with latest SciPy 1.15 #346

Open
larsoner opened this issue Jan 7, 2025 · 0 comments
Open

BUG: Cannot import neurodsp.timefrequency with latest SciPy 1.15 #346

larsoner opened this issue Jan 7, 2025 · 0 comments

Comments

@larsoner
Copy link

larsoner commented Jan 7, 2025

scipy.signal.morlet has been removed so you get for example:

  File "/Applications/MNE-Python/1.9.0_0/.mne-python/lib/python3.12/site-packages/bycycle/features/shape.py", line 6, in <module>
    from neurodsp.timefrequency import amp_by_time
  File "/Applications/MNE-Python/1.9.0_0/.mne-python/lib/python3.12/site-packages/neurodsp/timefrequency/__init__.py", line 4, in <module>
    from .wavelets import compute_wavelet_transform, convolve_wavelet
  File "/Applications/MNE-Python/1.9.0_0/.mne-python/lib/python3.12/site-packages/neurodsp/timefrequency/wavelets.py", line 4, in <module>
    from scipy.signal import morlet
ImportError: cannot import name 'morlet' from 'scipy.signal' (/Applications/MNE-Python/1.9.0_0/.mne-python/lib/python3.12/site-packages/scipy/signal/__init__.py)
Error: Process completed with exit code 1.

Eventually you might want a good long-term solution, but for now I'd suggest perhaps just to vendor the old code. I can open a quick PR to do that if it would help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant