-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NTRN-163] add dex stargate helpers #121
Conversation
71dcd98
to
aa40227
Compare
67459a0
to
3614caf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add proto generator script (partially done by @sotnikov-s, but not in scope of this PR because of time pressure);
Could you attach at least a WIP script here?
Because we need to finish it at least
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
And a suggestion, i can see there is the Name
trait in prost repo - https://github.com/tokio-rs/prost/blob/master/src/name.rs#L7 which potentially could let you avoid handcrafted helpers (msg_dex, query_dex) by generating appropriate type names.
Co-authored-by: Mike Mozhaev <[email protected]>
created a task for it and assigned to myself: https://hadronlabs.atlassian.net/browse/NTRN-192 |
task: https://hadronlabs.atlassian.net/browse/NTRN-163
this PR:
build_proto
stuff the repo contains for it's outdated and actually useless;neutron_sdk::stargate::proto_types
package which contains all neutron-specific proto types generated in rust;neutron_sdk::stargate
package which contains stargate query/msg helper funcs and types only for the dex module atm.to be done in by a future release:
i64
instead ofTimestamp
,Pool_metadata
->pool_metadata
);PrecDec
data type (used here https://github.com/neutron-org/neutron/blob/168815d3703a803f97566f2ddaf0954ac8bda203/proto/neutron/dex/params.proto#L14 and in a couple of other places).related PRs: