Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NTRN-163] add dex stargate helpers #121

Merged
merged 44 commits into from
Dec 14, 2023
Merged

[NTRN-163] add dex stargate helpers #121

merged 44 commits into from
Dec 14, 2023

Conversation

NeverHappened
Copy link
Contributor

@NeverHappened NeverHappened commented Nov 16, 2023

task: https://hadronlabs.atlassian.net/browse/NTRN-163

this PR:

  • removes build_proto stuff the repo contains for it's outdated and actually useless;
  • adds a neutron_sdk::stargate::proto_types package which contains all neutron-specific proto types generated in rust;
  • adds a neutron_sdk::stargate package which contains stargate query/msg helper funcs and types only for the dex module atm.

to be done in by a future release:

related PRs:

@NeverHappened NeverHappened self-assigned this Nov 16, 2023
@sotnikov-s sotnikov-s force-pushed the feat/dex-proto branch 3 times, most recently from 67459a0 to 3614caf Compare December 4, 2023 19:11
@sotnikov-s sotnikov-s changed the title feat: dex proto [NTRN-163] add dex stargate helpers Dec 5, 2023
@sotnikov-s
Copy link
Contributor

Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add proto generator script (partially done by @sotnikov-s, but not in scope of this PR because of time pressure);

Could you attach at least a WIP script here?
Because we need to finish it at least

packages/neutron-sdk/src/stargate/aux.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/stargate/types_dex.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/stargate/aux.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/stargate/aux.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/stargate/aux.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/stargate/msg_dex.rs Outdated Show resolved Hide resolved
packages/neutron-sdk/src/stargate/query_dex.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@swelf19 swelf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
And a suggestion, i can see there is the Name trait in prost repo - https://github.com/tokio-rs/prost/blob/master/src/name.rs#L7 which potentially could let you avoid handcrafted helpers (msg_dex, query_dex) by generating appropriate type names.

@sotnikov-s
Copy link
Contributor

@sotnikov-s
Copy link
Contributor

@sotnikov-s
Copy link
Contributor

add proto generator script (partially done by @sotnikov-s, but not in scope of this PR because of time pressure);

Could you attach at least a WIP script here? Because we need to finish it at least

created a task for it and assigned to myself: https://hadronlabs.atlassian.net/browse/NTRN-192

@pr0n00gler pr0n00gler merged commit d280443 into sdk/47 Dec 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants