Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc improvement: define a new type Loader<NixExpr> #36

Open
bryango opened this issue Mar 4, 2024 · 0 comments
Open

doc improvement: define a new type Loader<NixExpr> #36

bryango opened this issue Mar 4, 2024 · 0 comments

Comments

@bryango
Copy link

bryango commented Mar 4, 2024

Hi! I was trying to use a matcher and was confused by the

... ({ self, super, root, ... } -> Path -> a ) ...

everywhere in the doc. Only after I read the source did I realize that this is simply a loader. I believe it would be easier to define:

Loader<a> := { self, super, root, ... } -> Path -> a

... at the top of e.g. loaders and use that instead. Do you think this is a good idea? I am not sure if Loader<a> := is the nix way to annotate a new type, though; the angled brackets are simply borrowed from rust. Also, replacing some of the a with e.g. NixExpr would make it feel more descriptive to me.

If you all agree with this proposal but don't have time to implement this, I can try to submit a pull request, some time (I am very slow though, haha).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant