Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of Count-Based Rolling Window #817

Open
slice-arpitkhatri opened this issue Sep 27, 2023 · 3 comments
Open

Lack of Count-Based Rolling Window #817

slice-arpitkhatri opened this issue Sep 27, 2023 · 3 comments
Labels
enhancement help wanted status/no-issue-activity

Comments

@slice-arpitkhatri
Copy link

As per my understanding, we currently do not support a count-based rolling window. I want CB to act based on the last 50-odd requests. Since my TPS fluctuates between day and night, I have to adjust my rollingCountWindow based on TPS to ensure that there are at least 50 requests in the specific window.

Would it make sense to add count-based rolling window support?
@lholmquist
Copy link
Member

Could be interesting. If this is something you would like to work on, send a PR and we could walk through it

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

@github-actions GitHub Actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted status/no-issue-activity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lholmquist @slice-arpitkhatri