From 0cef265e83b5f705485556991c4b821f08f4969e Mon Sep 17 00:00:00 2001 From: shirady <57721533+shirady@users.noreply.github.com> Date: Tue, 14 Jan 2025 15:31:33 +0200 Subject: [PATCH] minor changes Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> --- src/test/unit_tests/test_s3_bucket_policy.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/test/unit_tests/test_s3_bucket_policy.js b/src/test/unit_tests/test_s3_bucket_policy.js index bf144edcd9..6f7cbf06d9 100644 --- a/src/test/unit_tests/test_s3_bucket_policy.js +++ b/src/test/unit_tests/test_s3_bucket_policy.js @@ -344,7 +344,7 @@ mocha.describe('s3_bucket_policy', function() { Bucket: BKT_D, }); }); - const allow_all_principal_all_s3_actions_statement = { + const allow_all_principals_all_s3_actions_statement = { Sid: `Allow all s3 actions on bucket ${BKT_D} to all principals`, Effect: 'Allow', Principal: { AWS: "*" }, @@ -370,14 +370,14 @@ mocha.describe('s3_bucket_policy', function() { }; mocha.it('should not allow principal get object bucket policy with 2 statements: ' + - '(1) DENY principal by account ID (2) ALLOW account name as *', async function() { + '(1) DENY principal by account ID (2) ALLOW all principals as *', async function() { // in NC we allow principal to be also IDs if (!is_nc_coretest) this.skip(); // eslint-disable-line no-invalid-this const deny_account_by_id_all_s3_actions_statement = get_deny_account_by_id_all_s3_actions_statement(user_a_account_details._id); const policy = { Statement: [ - allow_all_principal_all_s3_actions_statement, + allow_all_principals_all_s3_actions_statement, deny_account_by_id_all_s3_actions_statement ] }; @@ -409,10 +409,10 @@ mocha.describe('s3_bucket_policy', function() { }); mocha.it('should not allow principal get object bucket policy with 2 statements: ' + - '(1) DENY principal by account name (2) ALLOW account name as *', async function() { + '(1) DENY principal by account name (2) ALLOW all principals as *', async function() { const policy = { Statement: [ - allow_all_principal_all_s3_actions_statement, + allow_all_principals_all_s3_actions_statement, deny_account_by_name_all_s3_actions_statement ] };